feat/idle-channel-eviction #2651

nicholsl · 2025-08-01T14:58:50Z

Change-Id: I62fe152c293438bf64b657b5b1fe795e22ce9c85

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)
Rollback plan is reviewed and LGTMed
All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

Change-Id: I62fe152c293438bf64b657b5b1fe795e22ce9c85

Change-Id: I8d4212aad0ca7613b6c33d69d925671a090d1609

Change-Id: I9ad5eeaacb02ace9ba3cf7c09b6846dcbc298fb8

Change-Id: I04698ba82b95c82301e4e9f436401698675d7ea9

…googleapis#2649) * chore: Update generation configuration at Thu Jul 31 02:47:07 UTC 2025 * chore: Update generation configuration at Fri Aug 1 02:54:57 UTC 2025 * chore: Update generation configuration at Sat Aug 2 02:42:43 UTC 2025 * chore: generate libraries at Sat Aug 2 02:43:12 UTC 2025 * chore: Update generation configuration at Tue Aug 5 02:50:25 UTC 2025 * chore: generate libraries at Tue Aug 5 02:50:52 UTC 2025 * chore: Update generation configuration at Wed Aug 6 02:48:20 UTC 2025 * chore: generate libraries at Wed Aug 6 02:48:53 UTC 2025 * chore: Update generation configuration at Thu Aug 7 02:49:23 UTC 2025

* chore(main): release 2.64.0 * chore: generate libraries at Fri Aug 8 14:28:59 UTC 2025 --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: cloud-java-bot <[email protected]>

…e is slow (1m, 2 channel) (googleapis#2656) …conservative Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Rollback plan is reviewed and LGTMed - [ ] All new data plane features have a completed end to end testing plan Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

* chore(main): release 2.65.0 * chore: generate libraries at Tue Aug 12 16:25:49 UTC 2025 --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: cloud-java-bot <[email protected]>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

generated-files-bot · 2025-08-27T15:25:58Z

Warning: This pull request is touching the following templated files:

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableInstanceAdminClient.java
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/BaseBigtableInstanceAdminClientTest.java
proto-google-cloud-bigtable-admin-v2/src/main/java/com/google/bigtable/admin/v2/AppProfile.java
proto-google-cloud-bigtable-admin-v2/src/main/java/com/google/bigtable/admin/v2/AppProfileOrBuilder.java
proto-google-cloud-bigtable-admin-v2/src/main/java/com/google/bigtable/admin/v2/Instance.java
proto-google-cloud-bigtable-admin-v2/src/main/java/com/google/bigtable/admin/v2/InstanceOrBuilder.java
proto-google-cloud-bigtable-admin-v2/src/main/java/com/google/bigtable/admin/v2/InstanceProto.java
proto-google-cloud-bigtable-admin-v2/src/main/proto/google/bigtable/admin/v2/instance.proto
samples/snapshot/pom.xml

Change-Id: I3baa8e93bc614efe21f1159a708be36881120e34

Change-Id: I11e8da901a93a49009caf4caf0385fd5e3c8091b

Change-Id: Iaa30338d04ba846469fc6152e0683e53573c40ee

mutianf · 2025-08-28T17:53:24Z

...e-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/NoOpChannelPrimer.java

@@ -31,4 +33,11 @@ private NoOpChannelPrimer() {}
  public void primeChannel(ManagedChannel managedChannel) {
    // No op
  }
+
+  @Override
+  public SettableApiFuture<PingAndWarmResponse> sendPrimeRequestsAsync(ManagedChannel var1) {


nit

Suggested change

public SettableApiFuture<PingAndWarmResponse> sendPrimeRequestsAsync(ManagedChannel var1) {

public SettableApiFuture<PingAndWarmResponse> sendPrimeRequestsAsync(ManagedChannel channel) {

mutianf · 2025-08-28T17:57:29Z

...oud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/ChannelPoolHealthChecker.java

+import javax.annotation.Nullable;
+
+/** Class that manages the health checking in the BigtableChannelPool */
+public class ChannelPoolHealthChecker {


can this be package private?

mutianf · 2025-08-28T17:59:37Z

...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java

+    final ConcurrentLinkedQueue<ProbeResult> probeHistory = new ConcurrentLinkedQueue<>();
+
+    // we keep both so that we don't have to check size() on the ConcurrentLinkedQueue all the time
+    AtomicInteger failedProbesInWindow = new AtomicInteger();


mutianf · 2025-08-28T18:01:42Z

...oud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/ChannelPoolHealthChecker.java

+  // Window_Duration is the duration over which we keep probe results
+  private static final Duration WINDOW_DURATION = Duration.ofMinutes(5);
+  // Interval at which we probe channel health
+  static final Duration PROBE_INTERVAL = Duration.ofSeconds(30);


where else is this used? can it be private? or tagged with @visibileForTesting ?

mutianf · 2025-08-28T18:09:15Z

...oud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/ChannelPoolHealthChecker.java

+        BigtableChannelPrimer primer = (BigtableChannelPrimer) channelPrimer;
+        probeFuture = primer.sendPrimeRequestsAsync(entry.getManagedChannel());
+      } else if (channelPrimer instanceof NoOpChannelPrimer) {
+        NoOpChannelPrimer primer = (NoOpChannelPrimer) channelPrimer;


Do we want to probe if the channel primer is noop channel primer? sendPrimerRequestAsync doesn't do anything.

Hmm probably not. We can just have it fall into the continue block.

...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java

...oud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/ChannelPoolHealthChecker.java

mutianf · 2025-08-28T18:19:26Z

...oud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/ChannelPoolHealthChecker.java

+  /**
+   * Finds a channel that is an outlier in terms of health.
+   *
+   * @return Entry


nit:

Suggested change

* @return Entry

* @return the entry to be evicted. Returns null if nothing to evict.

mutianf · 2025-08-28T18:23:31Z

...oud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/ChannelPoolHealthChecker.java

+    executor.scheduleAtFixedRate(
+        this::detectAndRemoveOutlierEntries,
+        initialDelayDetect.toMillis(),
+        PROBE_INTERVAL.toMillis(),


I think we can schedule this task every MIN_EVICTION_INTERVAL millis, and we won't need the check in detectAndRemoveOutlierEntries?

Hmm, that probably works and would avoid some thread calls. I think it would make the channel eviction slightly less responsive though? It might mean that if a channel becomes unresponsive at time T = 10:02 it waits ~ 9:58 to get evicted.

...oud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/ChannelPoolHealthChecker.java

Change-Id: Ie0fde53cd17b1feeaaffd15382e936a46d84c5c1

feat/idle-channel-eviction

20e012d

Change-Id: I62fe152c293438bf64b657b5b1fe795e22ce9c85

nicholsl requested review from a team as code owners August 1, 2025 14:58

product-auto-label bot added size: l Pull request size is large. api: bigtable Issues related to the googleapis/java-bigtable API. labels Aug 1, 2025

nicholsl added 3 commits August 27, 2025 10:39

create noop channel primer

d2b6129

Change-Id: I8d4212aad0ca7613b6c33d69d925671a090d1609

no-op channel primer changes

333e9e9

Change-Id: I9ad5eeaacb02ace9ba3cf7c09b6846dcbc298fb8

update ignored diffs

4ddefce

Change-Id: I04698ba82b95c82301e4e9f436401698675d7ea9

nicholsl requested a review from a team as a code owner August 27, 2025 15:22

cloud-java-bot and others added 7 commits August 27, 2025 11:25

deps: update shared dependencies (googleapis#2654)

3646452

chore(main): release 2.65.1-SNAPSHOT (googleapis#2658)

171ac40

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

nicholsl and others added 4 commits August 27, 2025 11:46

Merge branch 'googleapis:main' into feat/idle-channel-eviction

5b619b1

more noop channel primer changes

862135b

Change-Id: I3baa8e93bc614efe21f1159a708be36881120e34

remove outdated comments

c0082cf

Change-Id: I11e8da901a93a49009caf4caf0385fd5e3c8091b

cleanup

7a007bf

Change-Id: Iaa30338d04ba846469fc6152e0683e53573c40ee

mutianf reviewed Aug 28, 2025

View reviewed changes

nicholsl and others added 2 commits August 28, 2025 16:04

pr feedback

beda46e

Change-Id: Ie0fde53cd17b1feeaaffd15382e936a46d84c5c1

Merge branch 'googleapis:main' into feat/idle-channel-eviction

dff1361

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat/idle-channel-eviction #2651

feat/idle-channel-eviction #2651

Uh oh!

nicholsl commented Aug 1, 2025

Uh oh!

generated-files-bot bot commented Aug 27, 2025

Uh oh!

mutianf Aug 28, 2025

Uh oh!

mutianf Aug 28, 2025

Uh oh!

mutianf Aug 28, 2025

Uh oh!

mutianf Aug 28, 2025

Uh oh!

mutianf Aug 28, 2025

Uh oh!

nicholsl Aug 28, 2025

Uh oh!

Uh oh!

Uh oh!

mutianf Aug 28, 2025

Uh oh!

mutianf Aug 28, 2025

Uh oh!

nicholsl Aug 28, 2025

Uh oh!

Uh oh!

Uh oh!

	public SettableApiFuture<PingAndWarmResponse> sendPrimeRequestsAsync(ManagedChannel var1) {
	public SettableApiFuture<PingAndWarmResponse> sendPrimeRequestsAsync(ManagedChannel channel) {

	* @return Entry
	* @return the entry to be evicted. Returns null if nothing to evict.

feat/idle-channel-eviction #2651

Are you sure you want to change the base?

feat/idle-channel-eviction #2651

Uh oh!

Conversation

nicholsl commented Aug 1, 2025

Uh oh!

generated-files-bot bot commented Aug 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!